Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert settings.gradle to kotlin #5147

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Oct 8, 2023

convert settings.gradle to kotlin

@Cervator
Copy link
Member

Cervator commented Oct 8, 2023

Seems straight forward enough, although I wonder is there any particular reasoning / added benefit to the change? I know sometimes Groovy stuff can be slow on its own.

@soloturn
Copy link
Contributor Author

Seems straight forward enough, although I wonder is there any particular reasoning / added benefit to the change? I know sometimes Groovy stuff can be slow on its own.

gradle switched the default:
https://blog.gradle.org/kotlin-dsl-is-now-the-default-for-new-gradle-builds

@soloturn
Copy link
Contributor Author

how do you normally get a review, a feedback or a merge, @Cervator @jdrueckert @BenjaminAmos ?

@jdrueckert
Copy link
Member

how do you normally get a review, a feedback or a merge, @Cervator @jdrueckert @BenjaminAmos ?

Easiest way to get attention is via discord. We do have a review-hotlist channel there. I personally also use the activity-feed channel which is synced with some repos and automatically shows new PRs, commits and comments.

Admittedly sometimes I see new changes but don't have time in that moment and then they slip my mind. Probably similar for others as well due to day job and other real life obligations.

It also frequently happens that people comment to ask something but when the answer comes don't approve. Or approve but don't merge. Not entirely sure why that is though.

settings.gradle.kts Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
@jdrueckert
Copy link
Member

@soloturn From my pov this can be merged once the checks are green again.
If I forget to check on this today again, apologies, please do ping me again for merging in that case.

@jdrueckert jdrueckert merged commit 4d79e5e into MovingBlocks:develop Oct 21, 2023
9 checks passed
@soloturn soloturn deleted the settings-gradle branch October 28, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants